Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated $proxy_ips and $trusted_proxy_ips parameters #2512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove deprecated $proxy_ips and $trusted_proxy_ips parameters #2512

wants to merge 2 commits into from

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Jan 2, 2024

Also simplifies the template by avoiding Optional[Array] = undef and instead treating empty arrays in that way.

@ekohl
Avoid Optional[Array] = undef in remoteip.conf.erb
9f9f32c 
By defaulting to an empty array and handling that the code is
simplified.
@ekohl ekohl requested review from bastelfreak, smortex and a team as code owners January 2, 2024 14:31
@ekohl ekohl mentioned this pull request Jan 2, 2024
Merged
3 tasks
@ekohl ekohl linked an issue Jan 2, 2024 that may be closed by this pull request
mod_remoteip doesn't add RemoteIpHeader in vhost #2456
Open
@ekohl ekohl mentioned this pull request Jan 2, 2024
Open
smortex
smortex approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
backwards-incompatible community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mod_remoteip doesn't add RemoteIpHeader in vhost
3 participants
@ekohl @smortex @ia-content